-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not compute FastBootService.request in the browser #201
Conversation
@@ -1,7 +1,7 @@ | |||
/* global FastBoot */ | |||
import Ember from "ember"; | |||
|
|||
const { deprecate, computed, get } = Ember; | |||
const { deprecate, computed, get, set } = Ember; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is set
being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nowhere after my last refactor. good catch!
Updated to remove |
@danmcclain any other blockers to merging? |
import { moduleFor, test } from 'ember-qunit'; | ||
|
||
moduleFor('service:fastboot', 'Unit | Service | fastboot in the browser', { | ||
// Specify the other units that are required for this test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need these comment lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😁
…-sync Remove usage of deprecated exists-sync
@danmcclain Whenever
FastBootService.request
was accessed in the browser, it was not handling_fastbootInfo.request
beingundefined
. This fix ensures that we returnnull
in that case just likeEmber.computed.readOnly
would.